During my tanker service in the AG in WWII I looked upon zigzagging as being almost fool-proof against sub attacks, but in recent times a lot of people have downplayed its importance, especially in the case of the sinking of the cruiser Indianapolis by a Japanese submarine and the subsequent court-martial of its captain for his failure to zigzag. A good discussion question here.